Skip to content

Issue 53328: AssayDefinitionModel.hasLookup to only consider the first sample lookup column for assay import cases#1859

Merged
cnathe merged 7 commits intodevelopfrom
fb_assaySampleLookup53328
Oct 3, 2025
Merged

Issue 53328: AssayDefinitionModel.hasLookup to only consider the first sample lookup column for assay import cases#1859
cnathe merged 7 commits intodevelopfrom
fb_assaySampleLookup53328

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented Oct 2, 2025

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=53328
The sample assay import menu items should only show an assay if the "first" sample column in the assay design is valid for the given sample type (i.e. lookup to All Samples or the specific sample type).

Related Pull Requests

Changes

  • assayDef.hasLookup to use just the first sample column for assay import case

@cnathe cnathe requested a review from labkey-susanh October 2, 2025 20:53
@cnathe cnathe self-assigned this Oct 2, 2025
Comment thread packages/components/src/internal/AssayDefinitionModel.ts Outdated
Comment thread packages/components/src/internal/AssayDefinitionModel.test.ts Outdated
@cnathe cnathe merged commit 88b4442 into develop Oct 3, 2025
3 checks passed
@cnathe cnathe deleted the fb_assaySampleLookup53328 branch October 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants