Misc exception fixes based on Mothership reports#1872
Merged
labkey-susanh merged 5 commits intodevelopfrom Oct 22, 2025
Merged
Conversation
cnathe
approved these changes
Oct 22, 2025
| permissionCheck: 'all' | 'any' = 'all' | ||
| ): boolean { | ||
| return checkPermissions(user.isAdmin, user.permissionsList, perms, checkIsAdmin, permissionCheck); | ||
| return checkPermissions(user?.isAdmin, user?.permissionsList, perms, checkIsAdmin, permissionCheck); |
Contributor
There was a problem hiding this comment.
minor: I believe that if user is undefined, this will end up returning false via checkPermissions, but would it make sense to just check for if (!user) return false; at the beginning?
Contributor
Author
There was a problem hiding this comment.
Since it is handled gracefully downstream, I'm going to leave this as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We've gotten various exception reports for null-like values. They seem like rare cases (or cases that I can't see how they would happen), but they are easy enough to protect against.
Related Pull Requests
Changes