Skip to content

Add/update links for the GitHub issues in /kanban/issues #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 2 commits into from
Nov 19, 2025
Merged

Add/update links for the GitHub issues in /kanban/issues #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057ff14
Add/update links for the GitHub issues in /kanban/issues
cnathe Nov 18, 2025
afab74b
remap kanban issue number to internal-issues number
cnathe Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export class AdvancedSettings extends React.PureComponent<AdvancedSettingsProps,
showDefaultValues = () => {
const { field, showDefaultValueSettings } = this.props;

// GitHub Issue #783: we don't yet support default values in the App
// GitHub Issue #298: we don't yet support default values in the App
if (isApp()) return false;

// some domains just don't support default values
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/domainproperties/models.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ describe('resolveBaseProperties', () => {
expect(field.rangeURI).toBe(SAMPLE_TYPE.rangeURI);
expect(field.required).toBe(true);

// GitHub Issue 787
// GitHub Issue #656
field = DomainField.resolveBaseProperties({ name: 'SampleId', required: false });
expect(field.dataType).toBe(SAMPLE_TYPE);
expect(field.conceptURI).toBe(SAMPLE_TYPE.conceptURI);
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/domainproperties/models.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ export class DomainField
field.dataType = SAMPLE_TYPE;
field.conceptURI = SAMPLE_TYPE.conceptURI;
field.rangeURI = SAMPLE_TYPE.rangeURI;
field.required = !!(raw.required ?? true); // GitHub Issue 787
field.required = !!(raw.required ?? true); // GitHub Issue #656
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/samples/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ export function createSessionAssayRunSummaryQuery(sampleIds: number[]): Promise<
assayRunsQuery = 'AssayRunsPerSampleChildFolder';
}

// GitHub Issue 748: need to account for the case with no sampleIds
// GitHub Issue #643: need to account for the case with no sampleIds
let whereClause = 'WHERE RowId IN (' + sampleIds.join(',') + ')\n';
if (sampleIds.length === 0) {
whereClause = 'WHERE 1 = 0\n'; // add where clause that will always result in zero rows
Expand Down
Loading