GitHub Issue 811: App permissions page shows deactivated users in group members list#1963
Merged
GitHub Issue 811: App permissions page shows deactivated users in group members list#1963
Conversation
… details on permissions page
… page to match what we do for permissions page
XingY
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
#811 LKSM shows deactivated users in site groups
This PR fixes a bug where deactivated users appeared in the group members panel on the app permissions page. It adds a userActive field to the Member and GroupMembership types, fetches the UserId/Active column from
core.Members, propagates it through the data pipeline, and uses it in two places: MembersList (permissions page — filters inactive users out entirely) and MemberButtons in labkey-ui-premium (group management page — shows
inactive users but prefixes them with "Inactive User:").
Related Pull Requests
Changes