GitHub Issue 954: Add error for duplicate values for parent inputs#1977
Open
GitHub Issue 954: Add error for duplicate values for parent inputs#1977
Conversation
XingY
changed the title
labkey-susanh
approved these changes
Apr 8, 2026
| }); | ||
|
|
||
| test('duplicate values', () => { | ||
| // single duplicate |
Contributor
There was a problem hiding this comment.
Rather than one test with comments on the test cases, this could be better done as separate tests with the comments acting as the test name.
| message = { message: lookupValidationErrorMessage(valueStr, true) }; | ||
| } else if (dupValues.size > 0) { | ||
| const valueStr = Array.from(dupValues) | ||
| .slice(0, 4) |
Contributor
There was a problem hiding this comment.
I assume the slicing is to keep the message size small and see that it's done in the previous block too, but it seems somewhat magical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 954: Add error for duplicate values for parent inputs
Related Pull Requests
Changes