Calculated Column Expression Assistant - Polish#2009
Merged
Conversation
cnathe
approved these changes
May 28, 2026
| jsonData: { | ||
| ...jsonData, | ||
| domainFields: domainFields?.map(f => (f instanceof DomainField ? DomainField.serialize(f) : f)), | ||
| field: serializedField, |
Contributor
There was a problem hiding this comment.
so the field here is the current calculated field that you are working on, right? I didn't look at the server side changes yet, but how is it using this field info? I see that it was previously using the field valueExpression, which makes sense, but what else about the field would be helpful (something like the name/label/descprition)?
Contributor
Author
There was a problem hiding this comment.
Yes, other metadata that it can refer to. I didn't want to caveat it too much right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses a number of things found during the initial testing of the expression assistant.
Related Pull Requests
Changes