Skip to content

@labkey/build - add explicit package dependencies#380

Merged
cnathe merged 14 commits intomasterfrom
fb_webpackBuildDependencies
Oct 28, 2020
Merged

@labkey/build - add explicit package dependencies#380
cnathe merged 14 commits intomasterfrom
fb_webpackBuildDependencies

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented Oct 28, 2020

Rationale

Since a specific version of the @labkey/build webpack configs will likely only work with a certain combination of package versions for the various webpack and loader packges, we'll declare those explicitly in its package.json

Related Pull Requests

Changes

  • Add explicit package.json dependencies for @labkey/build

Copy link
Copy Markdown
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a commented out reference to the need to add the dependency to platform's npmInstall command in the README.md that can now be removed.

@cnathe
Copy link
Copy Markdown
Contributor Author

cnathe commented Oct 28, 2020

There's a commented out reference to the need to add the dependency to platform's npmInstall command in the README.md that can now be removed.

Thanks for the reminder. Removed.

@cnathe cnathe merged commit b02123a into master Oct 28, 2020
@cnathe cnathe deleted the fb_webpackBuildDependencies branch October 28, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants