Sample finder polish #754
Merged
Sample finder polish #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype name to column name
…fb_sampleFinderPolishSusan
cnathe
approved these changes
Mar 2, 2022
| * Added getLabKeySqlWhere util | ||
| * Added InExpAncestorsOfFilterType and InExpDescendantsOfFilterType | ||
| * Enable non-text fields for EntityFieldFilterModal (Sample Finder) | ||
| * Add "showing all generations" message |
Contributor
There was a problem hiding this comment.
hmmm, should this message be up with your 2.138.X notes?
Contributor
Author
There was a problem hiding this comment.
Oops! Thanks. Actually just removing this as no longer relevant.
| <div className="pull-left"> | ||
| <div className="secondary-text">{capitalizeFirstChar(entityDataType.nounAsParentSingular)}</div> | ||
| <div className="primary-text">{schemaQuery.queryName}</div> | ||
| <div className="primary-text">{dataTypeDisplayName}</div> |
Contributor
There was a problem hiding this comment.
any reason to fall back on using the schemaQuery.queryName here and below (i.e. dataTypeDisplayName ?? schemaQuery.queryName)? I assume not, but just checking since it looks like dataTypeDisplayName is an optional prop.
Contributor
Author
There was a problem hiding this comment.
Yes, good idea. In practice, currently, it will never not be defined, but that's a better fallback.
| padding-bottom: 5px; | ||
| } | ||
|
|
||
| .filter-results__message { |
Contributor
There was a problem hiding this comment.
is this still needed with the move of the "all generations" text to the page subtitle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We're releasing Sample Finder in 22.3 and just need to polish a few parts of it before we do that.
Related Pull Requests
Changes
containerFilterproperty toEntityDataTypemodel