Skip to content

Fix PI-purchased NHP flag date check#1684

Merged
brentlogan merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_fixLeaseFeesForPIOwnedNHPs
Apr 8, 2026
Merged

Fix PI-purchased NHP flag date check#1684
brentlogan merged 3 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_fixLeaseFeesForPIOwnedNHPs

Conversation

@brentlogan
Copy link
Copy Markdown
Collaborator

@brentlogan brentlogan commented Apr 6, 2026

Rationale

The date comparison between the assignment start date and the NHP-purchased flag included time, leading to unexpected failures.

Related Pull Requests

Changes

  • Simplify the assignment/PI-purchased flag date comparison code for lease fees and lease fee adjustments
  • Exempt PI-purchased NHPs from lease setup fees
  • Delete cut-and-paste error/duplicate code
  • Update comments
  • Minor formatting

@brentlogan brentlogan requested a review from jonesgaohsu April 8, 2026 15:36
Copy link
Copy Markdown
Collaborator

@jonesgaohsu jonesgaohsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFeviewed the code changes with BRent all looks good

@brentlogan brentlogan merged commit 6c6dafe into release25.11-SNAPSHOT Apr 8, 2026
7 checks passed
@brentlogan brentlogan deleted the 25.11_fb_fixLeaseFeesForPIOwnedNHPs branch April 8, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants