Skip to content

Issue 34117: Low effort ways to get some kind of remote pipeline auto…#1023

Merged
labkey-jeckels merged 3 commits into
developfrom
fb_34117_remotePipelineTesting
Apr 8, 2020
Merged

Issue 34117: Low effort ways to get some kind of remote pipeline auto…#1023
labkey-jeckels merged 3 commits into
developfrom
fb_34117_remotePipelineTesting

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

…mated testing

Copy link
Copy Markdown
Collaborator

@bbimber bbimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-jeckels see comment about exit codes

if (args.length < 1)
{
System.out.println("No job file provided, exiting");
System.exit(0);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-jeckels This was on purpose. The use case is to verify the cluster process can start. we use it on our cluster after upgrades. It will also break the tests I just added

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be reasonable to support a new arg to explicitly say we dont expect to run a job, like "-dryRun" or something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I misinterpreted the comments. Please check the latest changes I pushed, which include core test coverage for the extract-only usage

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks good. glad we finally have this in place!

@labkey-jeckels labkey-jeckels merged commit 97305f6 into develop Apr 8, 2020
@labkey-jeckels labkey-jeckels deleted the fb_34117_remotePipelineTesting branch April 8, 2020 23:03
cnathe added a commit that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants