Allow transformed run properties to be imported based on property name, label, or import alias #6025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, label, or import alias - currently only supports name
labkey-klum
approved these changes
Nov 6, 2024
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently if your assay design has a transform script that writes to the transformedRunPropertiesFile to update / set run property values, those run prop keys must match the run property Name. This PR updates that server side parsing code to allow for importing via transformedRunPropertiesFile to match the property Name, Label, or Import Aliases.
Changes