Skip to content

DataIteratorUtil createTableMap support for matching on encoded fieldKey for insert/update/save rows#6270

Closed
cnathe wants to merge 1 commit intodevelopfrom
fb_tableMapFieldKey
Closed

DataIteratorUtil createTableMap support for matching on encoded fieldKey for insert/update/save rows#6270
cnathe wants to merge 1 commit intodevelopfrom
fb_tableMapFieldKey

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Feb 3, 2025

Rationale

One of the recent special characters issues that we fixed had to do with the app using fieldKeys instead of column names when posting the data from a Details form to the updateRows API. For those rows without any encoded special characters, this wasn't an issue but for those with the encoded special characters, the columns were not being resolved for the target table. In the data iterator code that handles this "column matching" we already support matching the column on name, label, uri, alias, among other things. This PR adds in the encoded fieldKey to the table column map that is used for this matching.

Related Pull Requests

Changes

  • DataIteratorUtil createTableMap support for matching on column encoded fieldKey

Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should add unit tests somewhere. I'm not sure what coverage we have for this server-side code already, but at the moment our applications are likely not going to hit this code path.

@cnathe
Copy link
Contributor Author

cnathe commented Feb 3, 2025

Probably we should add unit tests somewhere. I'm not sure what coverage we have for this server-side code already, but at the moment our applications are likely not going to hit this code path.

Yes for sure. I was opening this as a Draft PR to get review on the overall approach before I started on adding any tests for the change. I will for surely do so before we merge this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants