DataIteratorUtil createTableMap support for matching on encoded fieldKey for insert/update/save rows#6270
Closed
DataIteratorUtil createTableMap support for matching on encoded fieldKey for insert/update/save rows#6270
Conversation
…Key for insert/update/save rows
Contributor
labkey-susanh
left a comment
There was a problem hiding this comment.
Probably we should add unit tests somewhere. I'm not sure what coverage we have for this server-side code already, but at the moment our applications are likely not going to hit this code path.
Contributor
Author
Yes for sure. I was opening this as a Draft PR to get review on the overall approach before I started on adding any tests for the change. I will for surely do so before we merge this PR. Thanks. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
One of the recent special characters issues that we fixed had to do with the app using fieldKeys instead of column names when posting the data from a Details form to the updateRows API. For those rows without any encoded special characters, this wasn't an issue but for those with the encoded special characters, the columns were not being resolved for the target table. In the data iterator code that handles this "column matching" we already support matching the column on name, label, uri, alias, among other things. This PR adds in the encoded fieldKey to the table column map that is used for this matching.
Related Pull Requests
Changes