Fix assorted exceptions from bots/crawlers#6608
Merged
labkey-jeckels merged 6 commits intodevelopfrom Apr 29, 2025
Merged
Conversation
labkey-adam
requested changes
Apr 28, 2025
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
ThreadView user isn't used
| if (reshow) | ||
| { | ||
| String rendererTypeName = (String) form.get("rendererType"); | ||
| String rendererTypeName = form.get("rendererType"); |
Contributor
There was a problem hiding this comment.
FYI: Could replace these five lines with a one-line call to EnumUtils.getEnum()
|
|
||
| @RequiresPermission(ReadPermission.class) | ||
| public class RssAction extends SimpleViewAction | ||
| public class RssAction extends SimpleViewAction<Object> |
| } | ||
|
|
||
| protected void init(Container c, AnnouncementModel ann, URLHelper currentURL, Permissions perm, boolean isResponse, boolean print) | ||
| protected void init(Container c, AnnouncementModel ann, URLHelper currentURL, Permissions perm, boolean isResponse, boolean print, User user) |
Contributor
There was a problem hiding this comment.
Am I missing something? user is not used.
Contributor
Author
There was a problem hiding this comment.
Correct, I ended up not needing it. Reverted.
labkey-adam
reviewed
Apr 28, 2025
| } | ||
|
|
||
| public ThreadView(Container c, ActionURL url, AnnouncementModel ann, Permissions perm) | ||
| public ThreadView(Container c, ActionURL url, AnnouncementModel ann, Permissions perm, User user) |
Contributor
There was a problem hiding this comment.
I don't really care, but user is unused
Contributor
Author
There was a problem hiding this comment.
Oh, yes. I removed one but not the other levels. Another try now pushed.
labkey-adam
reviewed
Apr 28, 2025
| } | ||
|
|
||
| public ThreadView(AnnouncementForm form, Container c, ActionURL url, Permissions perm, boolean print) | ||
| public ThreadView(AnnouncementForm form, Container c, ActionURL url, Permissions perm, boolean print, User user) |
labkey-adam
approved these changes
Apr 28, 2025
XingY
pushed a commit
that referenced
this pull request
Apr 30, 2025
* Try to track down OutOfMemoryError saving custom view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Changes