Merge fb_long_identifiers changes into fb_databaseidentifier#6616
Merged
labkey-adam merged 34 commits intofb_databaseidentifierfrom Apr 30, 2025
Merged
Merge fb_long_identifiers changes into fb_databaseidentifier#6616labkey-adam merged 34 commits intofb_databaseidentifierfrom
labkey-adam merged 34 commits intofb_databaseidentifierfrom
Conversation
…ough more code paths.
…e awkward truncation rule
… method names, new surrogate-pair-aware char truncation methods, test for broken surrogates. Also, code review feedback.
labkey-matthewb
added a commit
that referenced
this pull request
May 1, 2025
* I don't think we need placeholder Results(null) * null check * DatabaseIdentifier ColumnInfo.getAlias() ColumnInfo.getSelectName() * DatabaseIdentifier * use SimpleFilter.getSQLFragment(tableInfo) * TableInfo.getMetaDataName() * comment * rm _defaultTableInfo * sweep for usages of makeLegalIdentiier() and append(alias) * DatabaseIdentifier.getString() -> getid() some fuzz testing * more fuzz testing fix double-quoting (makeLegalIdentifier) of names in specimen land * fix exp.xml * fix un-tabled columinfo * oops * sql generation * makeDatabaseIdentifier() * oor * !equals() * search for "+ col.getAlias() +" (implicit .toString()) * support STR_TABLE_ALIAS in SimpleFilter.SQLClause * support STR_TABLE_ALIAS in SimpleFilter.SQLClause * SampleDatasetTable fix * getProperties() * newCohortLabel * replace .get(column.getAlias()) * rm assert * StringBuilder -> SQLFragment * createMetaDataNameMap() * SQLClause reorg * aggregateResults map is weird * StringBuilder->SQLFragment also assert in DatabaseIdentifier.toString() to find teamcity failures * alias.toString() * StringBuilder->SQLFragment * test fix? * rename get*Name() -> get*Identifier() * this one weird trick will fix your MS2Test * generate alias for not-in-database columninfo * Fix merge conflicts * columnName -> columnNameFragment * Comments and visibility * Mostly spelling * remove AntTask debug hack * Imports * Merge fb_long_identifiers changes into fb_databaseidentifier (#6616) * getAlias().getId() * @NotNull SqlDialect * More cleanup * CTE(SqlDialect) * Test fix * patch up missing dialect in ScriptEngineReport temporary fix * comment --------- Co-authored-by: Adam Rauch <adam@labkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Merging the long identifiers changes into the database identifiers feature branch: #6564 --> #6498