Fix multi-valued input form fields#6674
Merged
labkey-adam merged 5 commits intodevelopfrom May 18, 2025
Merged
Conversation
XingY
approved these changes
May 16, 2025
| sb.append(delim); | ||
| sb.append(name); | ||
| delim = ","; | ||
| delim = ", "; |
Contributor
There was a problem hiding this comment.
I added space here because we do everywhere else.
| return values(ctx, _column::getInputValue); | ||
| } | ||
|
|
||
| // Issue 52983: This override matches the DisplayColumn.renderInputCell() implementation. |
Contributor
There was a problem hiding this comment.
Revised this comment to refer to this issue.
Contributor
Author
There was a problem hiding this comment.
And whoever splits the values trims them, right?
Contributor
There was a problem hiding this comment.
(I presume this comment was actually in reference to the other comment I made):
I added space here because we do everywhere else.
Yes, AliasInsertHelper does this and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The cell line update form stopped rendering the multi-valued alias field correctly. A
DisplayColumnrefactor a couple months ago removed a method override inMultiValuedDisplayColumn; this puts it back.https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=52983
Related Pull Requests