Issue 52925: App export to csv/tsv ignores filter with column containing double quote#6694
Merged
Issue 52925: App export to csv/tsv ignores filter with column containing double quote#6694
Conversation
Contributor
|
adding @labkey-matthewb to reviewers as an FYI since I know he has been in these discussions in the past re: % char encoding on FormData |
cnathe
requested changes
May 26, 2025
labkey-matthewb
requested changes
May 27, 2025
| continue; | ||
|
|
||
| String paramName = pv.getName(); | ||
| if (isFormDataEncoded) |
Contributor
There was a problem hiding this comment.
Can we do this fix up much earlier when we create the PropertyValues? e.g. wrapper for new ServletRequestParameterPropertyValues(request)?
Contributor
Author
There was a problem hiding this comment.
Good suggestion. A new ViewActionParameterPropertyValues class has been created.
cnathe
reviewed
May 28, 2025
Contributor
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
PR changes look good to me. I'll let @labkey-matthewb give the final review of the BaseViewAction changes.
labkey-matthewb
approved these changes
May 28, 2025
cnathe
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There is a bug with multipart/form-data that converts double quote " to %22. We had previously done some work to handle data rows for query actions (#6580). Separately, there was a workaround that's put in to handle assay upload from App (#6585). Like with the assay upload from App case, this issue with csv/tsv export is a localized scenario limited to Apps. So a similar encode on client and decode on server approach is used to handle this scenario.
Also included in PR:
Issue 52984: Add metric for duplicate material names of the same sample type
Related Pull Requests
Issue 52925: App export to csv/tsv ignores filter with column containing double quote labkey-ui-components#1797
https://github.com/LabKey/labkey-ui-premium/pull/759
Issue 52925: App export to csv/tsv ignores filter with column containing double quote #6694
https://github.com/LabKey/limsModules/pull/1426
Issue 52827: File/attachment fields with special characters #6580
Changes