Avoid assertion during AssayTransformImportUpdateTest#6752
Merged
labkey-jeckels merged 5 commits intodevelopfrom Jun 24, 2025
Merged
Avoid assertion during AssayTransformImportUpdateTest#6752labkey-jeckels merged 5 commits intodevelopfrom
labkey-jeckels merged 5 commits intodevelopfrom
Conversation
…AssayTransformJob
Contributor
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
I'm not sure I have much to add here, but it's gratifying to see this test running into issues we didn't expect it to
labkey-nicka
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This test is hitting an assert due to a race condition when one thread kills DB connections on another's behalf.
Failure:
https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyCPostgres/3545407
Test of FB:
https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyCPostgres?branch=raceConditionKillingConnection&buildTypeTab=overview
Changes