Postgres specific implementation of ROUND()#6789
Merged
labkey-matthewb merged 2 commits intorelease25.3-SNAPSHOTfrom Jun 25, 2025
Merged
Postgres specific implementation of ROUND()#6789labkey-matthewb merged 2 commits intorelease25.3-SNAPSHOTfrom
labkey-matthewb merged 2 commits intorelease25.3-SNAPSHOTfrom
Conversation
labkey-adam
approved these changes
Jun 24, 2025
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
Some suggestions in my comments
| else if (dialect.isPostgreSQL()) | ||
| { | ||
| /* fall through */ | ||
| // Postgres ROUND() requires NUMERIC argument and will error with DOUBLE |
Contributor
There was a problem hiding this comment.
Move/update/consolidate the comment above (lines #829 - 831) into this comment?
| } | ||
| else | ||
| { | ||
| int n = Integer.MIN_VALUE; |
Contributor
There was a problem hiding this comment.
I believe PostgreSQL is the only dialect that doesn't support round double, so we should never get to this case. We could remove this block or at least add a comment. We could also default supportsRoundDouble() to return true to make it more obvious that PostgreSQL is the only exception.
Contributor
Author
There was a problem hiding this comment.
Added comment.
| labkeyMethod.put("round", new Method("round", JdbcType.DOUBLE, 1, 2) | ||
| { | ||
| @Override | ||
| @Override |
Contributor
Author
There was a problem hiding this comment.
Lots of TAB chars in this file. Can address in develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Postgres does not support ROUND(double) use explicit cast to NUMERIC(unspecified) as a work around.
Related Pull Requests
Changes