Report duplicate and overlapping database indices#6989
Merged
labkey-adam merged 6 commits intodevelopfrom Sep 4, 2025
Merged
Conversation
…q/pk followed by non-unique). Add standard column widths.
labkey-matthewb
approved these changes
Sep 3, 2025
Contributor
labkey-matthewb
left a comment
There was a problem hiding this comment.
Seems useful. Some overlapping indexes are not redundant. If you want index (RowId, Other) I don't think you can the (RowId) part is unique. So you end up with two indexes.
Contributor
Author
@labkey-matthewb see my most recent commit (committed earlier this morning)... it separates out a third group of valid overlaps: any PK or UQ index with a column list that's a subset of a non-unique index's column list. I think those are valid and all others are redundant, but please check my logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
New devtools action inspects all indexes in tables in module schemas and flags those with duplicate or overlapping column sets. In most (all?) cases these duplicates are unnecessary, causing bloat and perhaps inefficiency.
Move standard redirect methods and callers away from passing URL strings.
Tasks 📍
overlappingIndiceslink