Skip to content

Issue 53934: Remove stored amount "too precise" validation check on setting amount modal#7102

Merged
cnathe merged 5 commits intodevelopfrom
fb_amountPrecision53934
Oct 7, 2025
Merged

Issue 53934: Remove stored amount "too precise" validation check on setting amount modal#7102
cnathe merged 5 commits intodevelopfrom
fb_amountPrecision53934

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Oct 6, 2025

Rationale

Issue 53934: Sample Manager: show full precision on sample amount edit
Issue 53978: Inconsistent enforcement of precision in different places you can enter amounts

See ui-components PR for rationale.

Related Pull Requests

Changes

StoredAmount / RawAmount display formatting to be done with DisplayColumnFactory

  • use sample type precision for formatting if the columnInfo doesn't have a user defined format
  • remove ROUND() from StoredAmount ExprColumn since we need to have access to value and displayValue on client side

cnathe added 2 commits October 3, 2025 14:51
…lumnFactory

- use sample type precision for formatting if the columnInfo doesn't have a user defined format
- remove ROUND() from StoredAmount ExprColumn since we need to have access to value and displayValue on client side
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the stored amount "too precise" validation check on setting amount modal and refactors how sample amount precision is handled. The changes move precision formatting from SQL-level ROUND() operations to client-side display formatting using a new DisplayColumnFactory.

  • Removes SQL ROUND() function from StoredAmount ExprColumn to provide access to both raw value and display value on client side
  • Introduces SampleTypeAmountPrecisionDisplayColumn class to handle precision formatting at display time
  • Updates amount column configuration to use the new display column factory for consistent precision handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cnathe cnathe merged commit 5700e09 into develop Oct 7, 2025
9 of 15 checks passed
@cnathe cnathe deleted the fb_amountPrecision53934 branch October 7, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants