Issue 53934: Remove stored amount "too precise" validation check on setting amount modal#7102
Merged
Issue 53934: Remove stored amount "too precise" validation check on setting amount modal#7102
Conversation
…lumnFactory - use sample type precision for formatting if the columnInfo doesn't have a user defined format - remove ROUND() from StoredAmount ExprColumn since we need to have access to value and displayValue on client side
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the stored amount "too precise" validation check on setting amount modal and refactors how sample amount precision is handled. The changes move precision formatting from SQL-level ROUND() operations to client-side display formatting using a new DisplayColumnFactory.
- Removes SQL ROUND() function from StoredAmount ExprColumn to provide access to both raw value and display value on client side
- Introduces SampleTypeAmountPrecisionDisplayColumn class to handle precision formatting at display time
- Updates amount column configuration to use the new display column factory for consistent precision handling
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
experiment/src/org/labkey/experiment/api/ExpMaterialTableImpl.java
Outdated
Show resolved
Hide resolved
labkey-susanh
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 53934: Sample Manager: show full precision on sample amount edit
Issue 53978: Inconsistent enforcement of precision in different places you can enter amounts
See ui-components PR for rationale.
Related Pull Requests
Changes
StoredAmount / RawAmount display formatting to be done with DisplayColumnFactory