Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

JavaScript regex replacement has several special replacement strings that start with $. Random domain name generation might stumble into one of them, so we need to use the function replacement instead.

FAILED
Error: expect(received).toBe(expected) // Object.is equality
Expected: "Invalid DataClass name 'cInvalid DataClass name ''. DataClass name may not contain any of these characters: <>[]{};,`\"~!@#$%^*=|?\\"
Received: "Invalid DataClass name 'c$`'. DataClass name may not contain any of these characters: <>[]{};,`\"~!@#$%^*=|?\\"
    at verifyDomainCreateFailure (/mnt/teamcity/work/a7b1f3583054d6ed/server/modules/platform/experiment/src/client/test/integration/utils.ts:466:52)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at checkDomainName (/mnt/teamcity/work/a7b1f3583054d6ed/server/modules/platform/experiment/src/client/test/integration/utils.ts:533:9)
    at Object.<anonymous> (/mnt/teamcity/work/a7b1f3583054d6ed/server/modules/platform/experiment/src/client/test/integration/DataClassCrud.ispec.ts:78:9)

Related Pull Requests

  • N/A

Changes

  • Handle tricky characters in domain name JavaScript test

@labkey-tchad labkey-tchad merged commit f75a811 into release25.11-SNAPSHOT Nov 7, 2025
11 checks passed
@labkey-tchad labkey-tchad deleted the 25.11_fb_someTestFixes branch November 7, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants