Skip to content

Fix primary product resolution when no product explicitly set#7213

Merged
labkey-susanh merged 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_productConfigIssues
Nov 18, 2025
Merged

Fix primary product resolution when no product explicitly set#7213
labkey-susanh merged 2 commits intorelease25.11-SNAPSHOTfrom
25.11_fb_productConfigIssues

Conversation

@labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Nov 18, 2025

Rationale

When a server has no product key explicitly set, we work with the set of modules to determine what the highest product available is in order to construct app URLs and the like. This logic is complicated because the product setting is global for the server but we also want to allow folders from lower products to be shown in a server with a higher product configured.

Yes, we really should be able to simplify this, but for now this PR and its related one fix the problem with the logic of finding the highest provider and adds some debugging logging in case we have other problems like this.

Repro steps for this issue:

  • Set up a Biologics product on a server where a product configuration has not been set
  • Create a subfolder (of type Collaboration)
  • Create a notebook in the subfolder
  • Search for the notebook using the global search
  • Click on the link for the search.

Result:

  • The URL for the link goes to lims-app.view instead of biologics-app.view
  • If you then search again from the lims-app.view page, the URL will get mangled to attach the biologics-app.view URL part at the end.

Related Pull Requests

Changes

  • Debug logging added for ProductConfiguration and ProductRegistry

Tasks 📍

  • Manual Testing @labkey-nicka
  • Needs Automation - not including an automated test because this problem scenario relies on a property not being set, and that property may be set by another test and, once set, cannot be unset.
  • Verify Fix

@labkey-susanh labkey-susanh self-assigned this Nov 18, 2025
Copy link
Contributor

@labkey-nicka labkey-nicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the repro scenario is fixed on this branch.

@labkey-susanh labkey-susanh merged commit 5376c8d into release25.11-SNAPSHOT Nov 18, 2025
12 checks passed
@labkey-susanh labkey-susanh deleted the 25.11_fb_productConfigIssues branch November 18, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants