Fix primary product resolution when no product explicitly set#7213
Merged
labkey-susanh merged 2 commits intorelease25.11-SNAPSHOTfrom Nov 18, 2025
Merged
Fix primary product resolution when no product explicitly set#7213labkey-susanh merged 2 commits intorelease25.11-SNAPSHOTfrom
labkey-susanh merged 2 commits intorelease25.11-SNAPSHOTfrom
Conversation
labkey-nicka
approved these changes
Nov 18, 2025
Contributor
labkey-nicka
left a comment
There was a problem hiding this comment.
Verified the repro scenario is fixed on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
When a server has no product key explicitly set, we work with the set of modules to determine what the highest product available is in order to construct app URLs and the like. This logic is complicated because the product setting is global for the server but we also want to allow folders from lower products to be shown in a server with a higher product configured.
Yes, we really should be able to simplify this, but for now this PR and its related one fix the problem with the logic of finding the highest provider and adds some debugging logging in case we have other problems like this.
Repro steps for this issue:
Result:
lims-app.viewinstead ofbiologics-app.viewlims-app.viewpage, the URL will get mangled to attach thebiologics-app.viewURL part at the end.Related Pull Requests
Changes
ProductConfigurationandProductRegistryTasks 📍
Needs Automation- not including an automated test because this problem scenario relies on a property not being set, and that property may be set by another test and, once set, cannot be unset.Verify Fix