Skip to content

GitHub Issue 925, 949 & 1014#7532

Merged
XingY merged 8 commits intodevelopfrom
fb_gh925
Mar 31, 2026
Merged

GitHub Issue 925, 949 & 1014#7532
XingY merged 8 commits intodevelopfrom
fb_gh925

Conversation

@XingY
Copy link
Copy Markdown
Contributor

@XingY XingY commented Mar 29, 2026

Rationale

GitHub Issue 949: Text choice value can be deleted if usage is added after loading designer
GitHub Issue 1014: Text choice value update doesn't update aliquot's aliquot-specific field values
GitHub Issue 925: Not providing a MVTC column in an assay import file throws error

Related Pull Requests

Changes

  • Fix issue where null value from absent MVTC column not processed as expected during assay import: multi-choice column values not being stored back into the map during assay import
  • text choice value renames not updating aliquot-specific field values, apply aliquot filter based on field's derivation scope settings
  • check text choice option usage on domain update

@XingY XingY requested a review from labkey-matthewb March 29, 2026 23:39
@XingY XingY changed the title GitHub Issue 925: Not providing a MVTC column in an assay import throws error GitHub Issue 925, 947 & 1014 Mar 30, 2026
@XingY XingY changed the title GitHub Issue 925, 947 & 1014 GitHub Issue 925, 949 & 1014 Mar 30, 2026

if (column != null)
{
SQLFragment sql = new SQLFragment("SELECT DISTINCT ")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be simplified using SqlDialect.array_some_in_array(), SqlDialect.array_construct() and SqlSelector().exist()?
something like

sql = SELECT 1
FROM tableInfo
WHERE dialect.array_some_in_array(dialect.array_construct(deleted), column.getAlias())
SqlExector(sql).exists();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do appendValue(String[])?
append("CAST(").addValue(array).append(" AS TEXT[])"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that works great.

@XingY XingY requested a review from labkey-matthewb March 30, 2026 23:08
@XingY XingY merged commit c693a96 into develop Mar 31, 2026
10 of 13 checks passed
@XingY XingY deleted the fb_gh925 branch March 31, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants