Conversation
labkey-matthewb
requested changes
Mar 30, 2026
|
|
||
| if (column != null) | ||
| { | ||
| SQLFragment sql = new SQLFragment("SELECT DISTINCT ") |
Contributor
There was a problem hiding this comment.
Can this be simplified using SqlDialect.array_some_in_array(), SqlDialect.array_construct() and SqlSelector().exist()?
something like
sql = SELECT 1
FROM tableInfo
WHERE dialect.array_some_in_array(dialect.array_construct(deleted), column.getAlias())
SqlExector(sql).exists();
Contributor
There was a problem hiding this comment.
I think we can do appendValue(String[])?
append("CAST(").addValue(array).append(" AS TEXT[])"
Contributor
Author
There was a problem hiding this comment.
Yep, that works great.
labkey-matthewb
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
GitHub Issue 949: Text choice value can be deleted if usage is added after loading designer
GitHub Issue 1014: Text choice value update doesn't update aliquot's aliquot-specific field values
GitHub Issue 925: Not providing a MVTC column in an assay import file throws error
Related Pull Requests
Changes