Skip to content

Use ReleaseVersion instead of no-longer-populated vcsTag#7542

Merged
labkey-susanh merged 5 commits intorelease26.3-SNAPSHOTfrom
26.3_fb_vcsTagReporting
Apr 3, 2026
Merged

Use ReleaseVersion instead of no-longer-populated vcsTag#7542
labkey-susanh merged 5 commits intorelease26.3-SNAPSHOTfrom
26.3_fb_vcsTagReporting

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented Apr 2, 2026

Rationale

vcsTag is no longer populated. Use ReleaseVersion instead for mothership reporting to track maintenance release versions.

Related PRs

Changes

  • Swap the source of the vcsTag module metadata submitted to mothership
  • Remove defunct vcsTag from Module interface

Tasks 📍

  • Manual Testing

@labkey-jeckels labkey-jeckels self-assigned this Apr 2, 2026
Copy link
Copy Markdown
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

I had to restore the setter because Spring was displeased having a vcsTag value in the XML without a matching field on the module class. Feel free to delete it. Or we can use the same FB to do it all at once.

@labkey-jeckels labkey-jeckels added this to the 26.03 milestone Apr 3, 2026
@labkey-susanh
Copy link
Copy Markdown
Contributor

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

I had to restore the setter because Spring was displeased having a vcsTag value in the XML without a matching field on the module class. Feel free to delete it. Or we can use the same FB to do it all at once.

Removed setter again after creating server branch with new gradle plugins version.

@labkey-susanh
Copy link
Copy Markdown
Contributor

I have verified that the vcsTag value shows up in the mothership data:

"Premium": {
"simpleMetricCounts": {
"controllerHits": {
"premium": 37
}
},
"assayExclusionCount": 0,
"qcTrendReportCount": 0,
"buildInfo": {
"vcsTag": "26.3-SNAPSHOT",
"buildTime": "Apr 3, 2026, 6:32:04 AM",
"moduleClass": "org.labkey.premium.PremiumModule",
"vcsBranch": "Unknown",
"buildNumber": "Unknown",
"vcsUrl": "Unknown",
"version": "26.000",
"vcsRevision": "Unknown"
},
...
}

and is not shown in the module info:

Screenshot 2026-04-03 at 6 51 40 AM

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

I had to restore the setter because Spring was displeased having a vcsTag value in the XML without a matching field on the module class. Feel free to delete it. Or we can use the same FB to do it all at once.

Removed setter again after creating server branch with new gradle plugins version.

Is there any value in keeping the setter around for pre-built modules with an old XML that might be deployed as-is? Or maybe we just add a release note and add the exception to our troubleshooting page?

@labkey-susanh
Copy link
Copy Markdown
Contributor

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

I had to restore the setter because Spring was displeased having a vcsTag value in the XML without a matching field on the module class. Feel free to delete it. Or we can use the same FB to do it all at once.

Removed setter again after creating server branch with new gradle plugins version.

Is there any value in keeping the setter around for pre-built modules with an old XML that might be deployed as-is? Or maybe we just add a release note and add the exception to our troubleshooting page?

If we don't remove it now, we'll want to try to remember to remove it later, but it is probably better to not have a breaking change for a maintenance release.

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

I guess if you're removing all the getters for the VcsTag property I can go ahead and remove its population from the gradle plugins as well.

I had to restore the setter because Spring was displeased having a vcsTag value in the XML without a matching field on the module class. Feel free to delete it. Or we can use the same FB to do it all at once.

Removed setter again after creating server branch with new gradle plugins version.

Is there any value in keeping the setter around for pre-built modules with an old XML that might be deployed as-is? Or maybe we just add a release note and add the exception to our troubleshooting page?

If we don't remove it now, we'll want to try to remember to remove it later, but it is probably better to not have a breaking change for a maintenance release.

Great point. Let's restore in this PR and yank it from develop once this is merged forward. I pushed a commit to bring it back temporarily.

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

@labkey-susanh labkey-susanh merged commit 295704c into release26.3-SNAPSHOT Apr 3, 2026
8 checks passed
@labkey-susanh labkey-susanh deleted the 26.3_fb_vcsTagReporting branch April 3, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants