Skip to content

Use correct method to write error message in JSP#7600

Merged
labkey-tchad merged 3 commits intodevelopfrom
fb_experimentGraphUpdate
Apr 17, 2026
Merged

Use correct method to write error message in JSP#7600
labkey-tchad merged 3 commits intodevelopfrom
fb_experimentGraphUpdate

Conversation

@labkey-tchad
Copy link
Copy Markdown
Member

@labkey-tchad labkey-tchad commented Apr 17, 2026

Rationale

LabKeyJspWriter complains if you call out.print.

java.lang.IllegalStateException: A JSP is attempting to render a string! '<p>Error rendering graph</p>' For help rectifying this problem, review this page https://www.labkey.org/Documentation/26.3/wiki-page.view?name=premServerEncoding&referrer=inPage or contact your LabKey Account Manager.
	at org.labkey.api.jsp.LabKeyJspWriter.throwException(LabKeyJspWriter.java:77)
	at org.labkey.api.jsp.LabKeyJspWriter.print(LabKeyJspWriter.java:54)
	at org.labkey.jsp.compiled.org.labkey.experiment.controllers.exp.experimentRunGraphView_jsp._jspService(experimentRunGraphView_jsp.java:219)

out.write does what we want.

Additionally. While the above error was useful for flagging this JSP issue, an empty graph shouldn't be throwing an exception.

Related Pull Requests

Changes

  • Use correct method to write error message in JSP
  • Don't throw an exception if the graph is empty
  • Log errors thrown when converting graph to SVG

@labkey-tchad labkey-tchad merged commit 5727364 into develop Apr 17, 2026
8 of 13 checks passed
@labkey-tchad labkey-tchad deleted the fb_experimentGraphUpdate branch April 17, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants