Skip to content

Improve nullability treatment for PageFlowUtil.urlProvider()#7618

Merged
labkey-jeckels merged 2 commits intodevelopfrom
fb_urlProvider
Apr 23, 2026
Merged

Improve nullability treatment for PageFlowUtil.urlProvider()#7618
labkey-jeckels merged 2 commits intodevelopfrom
fb_urlProvider

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

Rationale

The vast majority of callers of PageFlowUtil.urlProvider() are in the module that supplies the provider, or in a module that has a hard dependency on the supplying module. We can eliminate thousands of warnings in the code about null return values by differentiating between nullable and non-nullable use cases.

Changes

  • Split PageFlowUtil.urlProvider() (throws a clear exception instead of returning null) and PageFlowUtil.urlProviderOptional() (may return null)
  • Update select callers to eliminate their own null special-casing
  • Minor code cleanup

Tasks 📍

  • Manual Testing
  • Test Automation
  • Verify Fix

@labkey-jeckels labkey-jeckels merged commit fe48b84 into develop Apr 23, 2026
6 of 8 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_urlProvider branch April 23, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants