Skip to content

GitHub Issue #1087: App Admins cannot view the Schema Browser link from the apps#7620

Merged
cnathe merged 2 commits intorelease26.3-SNAPSHOTfrom
26.3_fb_schemaBrowser1087
Apr 24, 2026
Merged

GitHub Issue #1087: App Admins cannot view the Schema Browser link from the apps#7620
cnathe merged 2 commits intorelease26.3-SNAPSHOTfrom
26.3_fb_schemaBrowser1087

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented Apr 23, 2026

Rationale

#1087 App Admins cannot view the Schema Browser link from the apps

This is a companion to limsModules#2143. It adds a isTroubleShooter() convenience method to User.java following the same pattern as isAnalyst(), isBrowserDev(), etc., and then refactors PopupAdminView.java to use it.
This makes user.isTroubleShooter() available as a first-class helper so both the platform code and the limsModules menu providers can use consistent, readable permission checks.

Related Pull Requests

Changes

  • Add User helper for isTroubleShooter() for root permission check

@cnathe cnathe requested a review from labkey-susanh April 23, 2026 19:54
return hasRootPermissions(TRUSTED_BROWSER_DEV);
}

public boolean isTroubleShooter()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there aer several other places that could be updated to use this new method as well. No need to do it now, of course, but also seemingly low risk.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding a note to my todo list to make those updates in develop

@cnathe cnathe merged commit 54fb550 into release26.3-SNAPSHOT Apr 24, 2026
6 of 8 checks passed
@cnathe cnathe deleted the 26.3_fb_schemaBrowser1087 branch April 24, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants