TableInfo: ensure ExprColumn dependent columns are referenced#7638
Merged
labkey-nicka merged 2 commits intodevelopfrom May 5, 2026
Merged
TableInfo: ensure ExprColumn dependent columns are referenced#7638labkey-nicka merged 2 commits intodevelopfrom
labkey-nicka merged 2 commits intodevelopfrom
Conversation
labkey-matthewb
approved these changes
May 1, 2026
labkey-nicka
force-pushed
the
fb_referenced_columns
branch
from
68f06d9 to
896345a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses #1118 where
ExprColumnadded via table customizers are not having their dependent columns included in the query. As a result the generated query attempts to refer to columns that have not been furnished bygetFromSQL().Related Pull Requests
Changes
AbtractTableInfo, check if the mutation is anExprColumn, and update referenced columns