Skip to content

GitHub Issue #688: Sample's Created By and Modified By fields do not resolve correctly when added to assay results grid if sample lookup is set to a specific sample type#7640

Merged
cnathe merged 1 commit intorelease26.3-SNAPSHOTfrom
26.3_fb_backport688
May 4, 2026

Conversation

@cnathe
Copy link
Copy Markdown
Contributor

@cnathe cnathe commented May 4, 2026

Rationale

#688 Sample's Created By and Modified By fields do not resolve correctly when added to assay results grid if sample lookup is set to a specific sample type

This PR is a backport of the fix for GitHub issue #688 where CreatedBy and ModifiedBy fields fail to resolve when navigating through a sample lookup field (in an assay results grid) that targets a specific sample type. The fix replaces a
custom createLookupTableInfo() implementation — which manually called createMaterialTable() + populate() + overlayMetadata() — with a simpler delegation to getTable(tableName, cf), which goes through the schema's full
table construction pipeline and correctly sets up all FK columns including CreatedBy/ModifiedBy.

Related Pull Requests

Changes

  • use schema getTable() for materialIdForeignKey instead of custom createLookupTableInfo()
  • add test case to AssayTest

…eateLookupTableInfo()

- add test case to AssayTest
@cnathe cnathe requested a review from labkey-klum May 4, 2026 19:06
@cnathe cnathe merged commit 5297b9f into release26.3-SNAPSHOT May 4, 2026
8 of 10 checks passed
@cnathe cnathe deleted the 26.3_fb_backport688 branch May 4, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants