Skip to content

Auto-refactor assorted Java lint#7660

Open
labkey-jeckels wants to merge 3 commits intodevelopfrom
fb_lintCleanup
Open

Auto-refactor assorted Java lint#7660
labkey-jeckels wants to merge 3 commits intodevelopfrom
fb_lintCleanup

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

Rationale

Warnings can cover up important code quality issues.

Changes

  • SequencedCollections: get(0) -> getFirst(), etc
  • Add missing @NotNull/@Nullable
  • Simplify test assertions
  • Map operation simplification
  • Remove redundant throws clause
  • Switch to parameterized log message
  • C-style array -> Java-style array declaration
  • Delete overridden methods identical to parent
  • Switch statement -> enhanced switch statement
  • Remove redundant imports

Tasks 📍

  • Claude Code Review
  • Manual Testing
  • Test Automation

SequencedCollections: get(0) -> getFirst(), etc
Add missing @NotNull/@nullable
Simplify test assertions
Map operation simplification
Remove redundant throws clause
Switch to parameterized log message
C-style array -> Java-style array declaration
Delete overridden methods identical to parent
Switch statement -> enhanced switch statement
Remove redundant imports

@Override
public void write(byte b[], int off, int len) throws IOException
public void write(byte @NotNull[] b, int off, int len) throws IOException
@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

Tests are passing (BVT, Daily, External, EHR, Nightly, Nightly LKB, Nightly LKSM). Code scanning report is not new (though we should clear it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants