Audit schema migration: register handler and cast HasDetails varchar->boolean#7669
Open
labkey-martyp wants to merge 2 commits into
Open
Audit schema migration: register handler and cast HasDetails varchar->boolean#7669labkey-martyp wants to merge 2 commits into
labkey-martyp wants to merge 2 commits into
Conversation
…ean cast Audit tables are registered with DatabaseMigrationService so all source rows flow through the migration. Wraps the DatasetAuditDomain "HasDetails" column to CAST varchar source values to BIT and report JdbcType BOOLEAN, so the INSERT parameter binds cleanly into the target's boolean column on PG. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Audit tables need to flow through the SQL Server -> Postgres data migration. The
DatasetAuditDomain.HasDetailscolumn is varchar in some legacy source databasesbut boolean on the target. Without an explicit cast, the migration's INSERT
parameter inherits the source VARCHAR type and Postgres rejects the bound value
when writing to the target's boolean column.
Related Pull Requests
Changes
AuditModule.registerMigrationHandlersregisters the audit schema withDatabaseMigrationServiceso all source rows are carried.HasDetailsCastColumn(private staticWrappedColumn) wraps theHasDetailscolumn to emitCAST(... AS BIT)in the source SELECT and reportJdbcType.BOOLEAN.