support testing with serverContext on teamCity #1050
Conversation
# Conflicts: # gradle.properties
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
You downgraded a bunch of dependencies somehow. don't do that
Yikes. Pushed a change to align with right-now develop |
| ## We do not recommend deploying to a non-root context path (e.g. http://localhost:8080/labkey) | ||
| ## If you do set this property, do not set a legacyContextPath. | ||
| #context.contextPath=/labkey | ||
| #context.contextPath=@@contextPath@@ |
There was a problem hiding this comment.
This file (server/configs/webapps/embedded/config/application.properties) is the one we bundle with distributions. TeamCity doesn't care about it. Changing this probably won't cause any trouble but folks might have scripts that depend on the current text. Let's leave it as is; not worth the risk IMO.
There was a problem hiding this comment.
If that change isn't there, I worry the plugin won't uncomment that line. It does this check:
(DoThenSetup.groovy line 110)
if (configProperties.containsKey("contextPath") && line.contains("=@@contextPath")) { line = line.replace("#context.", "context.") }
If I undo this change, I think I'll have to check differently or else we don't effectively configure the server for the run.
...as I review my changes and the results, it's the one at server/configs/application.properties that seems to have resolved the problem of that line not being uncommented. I'll try reverting that change in the one at server/configs/webapps/embedded/config/ to see if it still works
(edit: it does work.)
Rationale
This change accompanies the changes made in LabKey/gradlePlugin#231 to support configuring teamCity runs to use a contextPath
Github story: https://github.com/LabKey/kanban/issues/664
Related Pull Requests
updates to gradle plug-in: LabKey/gradlePlugin#231
Changes
updates the gradle plug-in version