Remove versions for GWT and Jakarta annotations#1368
Conversation
|
@labkey-susanh My local build still works without these properties. Let me know if if it's best to wait for the Gradle plugin update before merging this. https://github.com/LabKey/internal-issues/issues/1143 |
| } | ||
| formats = ['HTML', 'JUNIT'] | ||
| skipConfigurations = ['dedupe', 'gwtCompileClasspath', 'gwtRuntimeClasspath', 'developmentOnly'] | ||
| skipConfigurations = ['dedupe', 'developmentOnly'] |
There was a problem hiding this comment.
@labkey-susanh let me know if this should remain until the Gradle plugin updates.
There was a problem hiding this comment.
If there are no modules with a directory called gwtsrc then there should be no modules that apply the GWT plugin, and thus none that have these configurations, so I believe it's safe to remove them. There's also, I think, no harm in leaving them and just making a note in the issue that is already open to clean these up when the plugins are updated to remove the GWT plugin.
SequencedCollections: get(0) -> getFirst(), etc Add missing @NotNull/@nullable Simplify test assertions Map operation simplification Remove redundant throws clause Switch to parameterized log message C-style array -> Java-style array declaration Delete overridden methods identical to parent Switch statement -> enhanced switch statement Remove redundant imports
| } | ||
| formats = ['HTML', 'JUNIT'] | ||
| skipConfigurations = ['dedupe', 'gwtCompileClasspath', 'gwtRuntimeClasspath', 'developmentOnly'] | ||
| skipConfigurations = ['dedupe', 'developmentOnly'] |
There was a problem hiding this comment.
If there are no modules with a directory called gwtsrc then there should be no modules that apply the GWT plugin, and thus none that have these configurations, so I believe it's safe to remove them. There's also, I think, no harm in leaving them and just making a note in the issue that is already open to clean these up when the plugins are updated to remove the GWT plugin.
2 participants
Rationale
We no longer depend on GWT.
Related Pull Requests
Changes