Bug fixes for birthdate changes and acquisition date selection#361
Merged
Bug fixes for birthdate changes and acquisition date selection#361
Conversation
2. Closed AcqCodes that haven't been used in the past five years (in tsv file)
3. Added missing acquisition codes to tsv file
4. Filtered acq code 97 from fetchAcquisitionTypes API
5. Removed the join on the v_demographics view from arrivals and departures ETL source queries - if animal is removed from the colony
before the ETL runs, then the deletion will be missed
6. Started refactoring retrieval of dams and sires to use a birthdate parameter
…dOptionParm parameter to account for differences in how potential sires and dams are handled depending on whether a birth or other acquisition is being recorded 2. fetchLocations.js API updated to filter based on acquisiton codes for offsite acquisitions 3. fetchPotentialDams.js and fetchPotentialSires.js APIs updated to handle SQL parameters 4. Changes to AccountPanel.jsx to allow non-birth acquisitions to have null accounts 5. Changes to AcquisitionPanel.js to reload location codes when acquisition type changes 6. Changes made to DemographicsPanel.js to reload dams and sires after birth date is entered 7. Added new constant offSiteAcqCodes to track acquisition of animals not being added to the colony 8. Updated request API to handle parameters 9. UpdateAnimalData.js to allow null animal accounts 10. Updated ANPRC_EHRValidator.java to permit null accounts in certain conditions 11. Updated Jest tests
2. changed how ehr_lookups.source is being populated - went from TSV
file to ETL
3. added source query for source locations -
labkey_etl.v_sourceLocations
4. added location description to lookup list
5. added sourceLocation to the updateAnimalData.js API
6. added sourceLocation to SummaryPanel.jsx - also tweaked hover text
locations
7. added sourceLocation to default state - NewAnimalState.js
8. added sourceLocation jest tests, test data, mock API
9. updated snapshots
10. many lint fixes including files outside the scope of this feature
branch
2. added query meta data for sourceLocation
…g in HandleBirthDateChange 3. code clean up 4. updated jest tests 5. updated snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixed error with reloading lists of sires and dams when birthdate changes
Related Pull Requests
none
Changes