Fix cost account ETL view returning multiple rows per charge id when a charge id has multiple species#914
Merged
jallentxbiomed merged 2 commits intorelease25.7-SNAPSHOTfrom May 6, 2026
Conversation
RameshRapa
reviewed
May 5, 2026
| WHERE vcs2.charge_id = ca.charge_id | ||
| ) vcs | ||
| LEFT OUTER JOIN dbo.prd_cost_account AS pca on pca.account_id = ca.account_id | ||
|
|
Collaborator
There was a problem hiding this comment.
SELECT TOP 1 without ORDER BY is non-deterministic — SQL Server may return a different species row across runs depending on the query plan. Please add ORDER BY vcs2.arc_species_code will guarantee consistent ETL output
RameshRapa
approved these changes
May 5, 2026
jallentxbiomed
deleted the
25.7_fb_fixChargeAccountsViewReturningDuplicates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.