Skip to content

Conversation

@vagisha
Copy link
Collaborator

@vagisha vagisha commented Feb 5, 2025

Rationale

When a Skyline document is moved to another folder, FilePathRoot on the moved ExpRun continues to point to the source container.

  • FilePathRoot gets set incorrectly in XarReader:
    vals.setFilePathRoot(FileUtil.getAbsolutePath(_xarSource.getRootPath()))
  • getRootPath() method in MoveRunsXarSource returns the root path in the source container.
  • Incorrect FilePathRoot causes the PanoramaPublic data copy pipeline to fail in PanoramaPublicFileImporter.alignDataFileUrls()

Questions:

  • Would it be better to fix this in XarReader instead of the targetedms? This draft PR has a potential fix: Set the FilePathRoot on moved run platform#6292
  • Would it be better to fix the FilePathRoot in the panoramapublic module instead, so that it only impacts PanoramaWeb?

Related issues and tickets:

Related Pull Requests

Changes

  • Update FilePathRoot in TargetedMSDataHandler

@vagisha vagisha marked this pull request as ready for review February 5, 2025 19:57
@vagisha vagisha changed the title Fix ExpRuns's FilePathRoot after a run is moved to another folder. Fix ExpRun's FilePathRoot after a run is moved to another folder. Feb 5, 2025
@vagisha
Copy link
Collaborator Author

vagisha commented Feb 13, 2025

Closing in favor of LabKey/platform#6292

@vagisha vagisha closed this Feb 13, 2025
@vagisha vagisha deleted the 24.11_fb_fix-filepathroot-on-move-run branch February 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants