Improved test coverage for peptide heatmap report#1089
Merged
labkey-jeckels merged 2 commits intodevelopfrom Jun 26, 2025
Merged
Improved test coverage for peptide heatmap report#1089labkey-jeckels merged 2 commits intodevelopfrom
labkey-jeckels merged 2 commits intodevelopfrom
Conversation
labkey-danield
approved these changes
Jun 26, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Your change will work, but consider the change I suggested for the PeptideSummaryWebPart.apply method.
test/src/org/labkey/test/components/targetedms/PeptideSummaryWebPart.java
Outdated
Show resolved
Hide resolved
test/src/org/labkey/test/tests/targetedms/TargetedMSPeptideSummaryHeatmapTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We've done a number of bug fixes for the peptide heat map summary report and want to avoid regressions.
Related Pull Requests
Changes