[bot] Fast-forward for 26.3.10#1217
Merged
Merged
Conversation
* flat protein/molecule list for a Skyline document
* match columns with Skyline file
* code review comment
* update text
* More direct Panorama links
* Self-review
* Fix build
* Remove extra import
* Fix test failures
* Comments
* Switch to centralized method
* Code review followup
* Another test fix
* Protein vs peptide group
* Missing files
* Better comments
* Self-review improvements
* Simplify after refactor
* Extract TargetedMSHelper and add upgrade test for 26.3 schema migration
Extracts setupFolder(), selectFolderType(), and importData() from TargetedMSTest
into a new TargetedMSHelper class so the logic can be shared without subclassing.
Adds TargetedMSUpgradeTest to verify the targetedms-26.006-26.007 migration correctly
populates PeptideGroupCount, MoleculeGroupCount, and ProteinCount on existing runs.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Protein group, not peptide group
* Protein group, not peptide group
* Split upgrade test into pre- and post-upgrade count checks; fix upgrade script and run summary labels
testPreUpgradeCounts queries columns available in 25.11 (Peptides, SmallMolecules,
Replicates) and runs on both setup and verify phases. testPostUpgradeCounts is
gated with @EarliestVersion("26.3") and Assume.assumeFalse(isUpgradeSetupPhase)
so it only runs after the 26.006-26.007 migration.
Also adds missing PeptideGroupCount NOT NULL constraint to the upgrade script and
renames 'peptide group' labels to 'protein group' in verifyRunSummaryCounts.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix field names
* Fix annotations
---------
Co-authored-by: labkey-jeckels <jeckels@labkey.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…on (#1211) * Extract TargetedMSHelper and add upgrade test for 26.3 schema migration Extracts setupFolder(), selectFolderType(), and importData() from TargetedMSTest into a new TargetedMSHelper class so the logic can be shared without subclassing. Adds TargetedMSUpgradeTest to verify the targetedms-26.006-26.007 migration correctly populates PeptideGroupCount, MoleculeGroupCount, and ProteinCount on existing runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Split upgrade test into pre- and post-upgrade count checks testPreUpgradeCounts queries columns available in 25.11 (Peptides, SmallMolecules, Replicates) and runs on both setup and verify phases. testPostUpgradeCounts is gated with @EarliestVersion("26.3") and Assume.assumeFalse(isUpgradeSetupPhase) so it only runs on the new server after the 26.006-26.007 migration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix field names * Not ready for Java 25 yet * Fix annotations --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
labkey-klum
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.10