Skip to content

Fix TargetedMSQCGuideSetTest - update to recognize new page when query doesn't exist#5

Closed
labkey-jeckels wants to merge 15 commits into
developfrom
fb_fixQueryExistenceCheck
Closed

Fix TargetedMSQCGuideSetTest - update to recognize new page when query doesn't exist#5
labkey-jeckels wants to merge 15 commits into
developfrom
fb_fixQueryExistenceCheck

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

No description provided.

labkey-jeckels and others added 13 commits May 29, 2019 14:57
Improve layout of QC Summary web part, including showing both sample name and acquisition time in a table layout.

Improve layout of email content, and make it a little more real in terms of subject, sender, etc.

Tweak layout and wording of QC notification subscription and metric selection UIs

Add column to track future support of run-scoped metrics
… a default guide set with all data points on the qc plot.
…table, which made it quite unsafe to cache. Now it is, and we can use a ContainerFilter (already handled via the caching code) to control the lookup behavior to get the same optimized query generated.
@labkey-tchad
Copy link
Copy Markdown
Member

@labkey-tchad
Copy link
Copy Markdown
Member

@labkey-jeckels Was this intended to be branched from fb_qcNotifications or was that an accident?

@labkey-jeckels
Copy link
Copy Markdown
Contributor Author

@labkey-tchad It was an accident. I thought I had switched back to develop before creating it, but evidently not. Will it be easiest to delete this branch and recreate?

@labkey-tchad
Copy link
Copy Markdown
Member

@labkey-jeckels You could also run git rebase --onto origin/develop fb_qcNotifications fb_fixQueryExistenceCheck if you're feeling adventurous.

@labkey-jeckels labkey-jeckels deleted the fb_fixQueryExistenceCheck branch June 10, 2019 17:50
nickshulman pushed a commit to nickshulman/targetedms that referenced this pull request Jan 31, 2021
… does not guarantee that listeners get replaced properly on the ModuleLoader/ModuleResourceCache side of things, but it helps. (LabKey#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants