Fix TargetedMSQCGuideSetTest - update to recognize new page when query doesn't exist#5
Closed
labkey-jeckels wants to merge 15 commits into
Closed
Fix TargetedMSQCGuideSetTest - update to recognize new page when query doesn't exist#5labkey-jeckels wants to merge 15 commits into
labkey-jeckels wants to merge 15 commits into
Conversation
Improve layout of QC Summary web part, including showing both sample name and acquisition time in a table layout. Improve layout of email content, and make it a little more real in terms of subject, sender, etc. Tweak layout and wording of QC notification subscription and metric selection UIs Add column to track future support of run-scoped metrics
… a default guide set with all data points on the qc plot.
…table, which made it quite unsafe to cache. Now it is, and we can use a ContainerFilter (already handled via the caching code) to control the lookup behavior to get the same optimized query generated.
Member
|
Waiting for TargetedMS suite: |
Member
|
@labkey-jeckels Was this intended to be branched from fb_qcNotifications or was that an accident? |
Contributor
Author
|
@labkey-tchad It was an accident. I thought I had switched back to develop before creating it, but evidently not. Will it be easiest to delete this branch and recreate? |
Member
|
@labkey-jeckels You could also run |
added 2 commits
June 10, 2019 10:46
…/targetedms into fb_fixQueryExistenceCheck
nickshulman
pushed a commit
to nickshulman/targetedms
that referenced
this pull request
Jan 31, 2021
… does not guarantee that listeners get replaced properly on the ModuleLoader/ModuleResourceCache side of things, but it helps. (LabKey#5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.