longer wait for file download#1979
Merged
labkey-chrisj merged 1 commit intorelease24.7-SNAPSHOTfrom Jul 12, 2024
Merged
Conversation
Contributor
Author
labkey-tchad
approved these changes
Jul 12, 2024
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Hope this does the trick 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
UploadLargeExcelAssayTest.testUpload200kRows is failing on 24.7 sql because it takes more than 10 seconds to complete downloading the large excel file the test exports.
This change gives it more time to complete downloading
Once this is passing in 24.7, I will want to merge this change (along with #1978) forward to develop - hopefully that will get
UploadLargeExcelAssayTestpassingRelated Pull Requests
Changes
use WAIT_FOR_PAGE (60 seconds) instead of WAIT_FOR_JAVASCRIPT (10 seconds) as download timeout