Merged
Conversation
labkey-danield
approved these changes
Nov 18, 2024
labkey-danield
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There are some more selenium tests that can be written. Some are "nice to have" others are waiting on issue resolutions.
Related Issue: https://github.com/LabKey/sampleManagement/issues/1117
Spec
Github epic
Issues:
Issue 46137: LKSM: Editing when a row is filtered out of a view doesn't show the row in edit
Issue 47257: Cannot delete samples from a grid that has a filter applied. - see details here
Should Do:
(https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=46022))
Related Pull Requests
https://github.com/LabKey/limsModules/pull/907
Changes