Use correct noun for field labels#2399
Merged
labkey-tchad merged 17 commits intodevelopfrom Apr 22, 2025
Merged
Conversation
labkey-tchad
changed the title
# Conflicts: # src/org/labkey/test/components/ui/grids/DetailTableEdit.java
labkey-chrisj
approved these changes
Apr 21, 2025
| @@ -88,9 +88,9 @@ public Boolean isLoaded() | |||
| */ | |||
| private WebElement getField(String identifier) | |||
Contributor
There was a problem hiding this comment.
I wonder if getField should become getFieldByLabel? (or perhaps, identifier could become 'label'?)
Just offering suggestions at this point
labkey-danield
approved these changes
Apr 22, 2025
| public List<String> getSummaryModeColumns() | ||
| { | ||
| var rawColumns = getSummaryModeGrid().getColumnNames(); | ||
| var rawColumns = getSummaryModeGrid().getColumnLabels(); |
Contributor
There was a problem hiding this comment.
Would it be more consistent to rename getColumnNames to getFieldLabels? Many of these other changes replaced Column with Field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
[Story]
Numerous tests refer to a field's "name" when they really mean its label or fieldKey. Methods and variable names should accurately reflect what they represent.
Related Pull Requests
Changes