Skip to content

Exclude POST-only confirmation actions from crawler#2471

Merged
labkey-tchad merged 1 commit intodevelopfrom
fb_anotherCrawlerNpe
May 30, 2025
Merged

Exclude POST-only confirmation actions from crawler#2471
labkey-tchad merged 1 commit intodevelopfrom
fb_anotherCrawlerNpe

Conversation

@labkey-tchad
Copy link
Copy Markdown
Member

Rationale

These actions only respond to POST. The crawler hits an NPE when deciding what to do with the 405 response. Since the crawler can't do anything useful with actions that don't respond to GET, we should just exclude them.

java.lang.RuntimeException: Crawler threw NullPointerException.
Target Page: Dataset%20Download%20Test/publish-assayPublishConfirm.view
  at org.labkey.test.util.Crawler.crawlLink(Crawler.java:1129)
  at org.labkey.test.util.Crawler.crawl(Crawler.java:838)
  at org.labkey.test.util.Crawler.crawlAllLinks(Crawler.java:801)
  at org.labkey.test.BaseWebDriverTest.checkLinks(BaseWebDriverTest.java:1648)
  at org.labkey.test.BaseWebDriverTest.doPostamble(BaseWebDriverTest.java:1265)
  [...]
Caused by: java.lang.NullPointerException: Cannot invoke "java.net.URL.toString()" because "url" is null
  at org.labkey.test.util.Crawler.isAdminSpiderAction(Crawler.java:1159)
  at org.labkey.test.util.Crawler.isIgnoredError(Crawler.java:1182)
  at org.labkey.test.util.Crawler.crawlLink(Crawler.java:1005)

Related Pull Requests

Changes

  • Exclude POST-only confirmation actions from crawler

@labkey-tchad labkey-tchad merged commit 351c4a9 into develop May 30, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the fb_anotherCrawlerNpe branch May 30, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants