Issue 52339: Change list domain URI construction to not use encoded user-provided names#2522
Issue 52339: Change list domain URI construction to not use encoded user-provided names#2522labkey-susanh merged 3 commits intodevelopfrom
Conversation
…ser-provided names
| @Test // Issue 52339 | ||
| public void testLongName() | ||
| { | ||
| String listName = "A_+-:''.¡™£¢∞§¶•ªº–≠œ∑´®†¥¨ˆøπ“‘«æ…¬˚∆˙©√ƒ∂ßΩ≈ç√∫µ≤≥÷‹›fifl‡°·‚—±⁄€‹›‡‰Æ«»¢∫√∑∏∂"; |
There was a problem hiding this comment.
Consider append a random string?
There was a problem hiding this comment.
Seems superfluous when the name is already ridiculously complex.
There was a problem hiding this comment.
Perhaps. It does lack certain pattern though, like whitespaces.
There was a problem hiding this comment.
I don't think any of these need to be escaped to unicode \u values. Was that your impression as well?
There was a problem hiding this comment.
The name of the list looks like it's as provided here. And, in any case, the particular characters are not all that important, just the fact that this leads to a really long URI encoded name.
| @Test // Issue 52339 | ||
| public void testLongName() | ||
| { | ||
| String listName = "A_+-:''.¡™£¢∞§¶•ªº–≠œ∑´®†¥¨ˆøπ“‘«æ…¬˚∆˙©√ƒ∂ßΩ≈ç√∫µ≤≥÷‹›fifl‡°·‚—±⁄€‹›‡‰Æ«»¢∫√∑∏∂"; |
There was a problem hiding this comment.
I don't think any of these need to be escaped to unicode \u values. Was that your impression as well?
3 participants
Rationale
Issue 52339: When names are too long, we exceed the limit of the domain URI field. We don't really need to use names in these URIs.
Related Pull Requests
Changes