Skip to content

Make FieldKey.fromFieldKey return null for invalid input#2524

Merged
labkey-tchad merged 3 commits intodevelopfrom
fb_fixFieldRefManagerNpe
Jun 28, 2025
Merged

Make FieldKey.fromFieldKey return null for invalid input#2524
labkey-tchad merged 3 commits intodevelopfrom
fb_fixFieldRefManagerNpe

Conversation

@labkey-tchad
Copy link
Member

Rationale

I removed this try/catch, hoping this could be a bit more strict but it's causing errors.

java.lang.IllegalArgumentException: FieldKey can't have blank part(s):
        at org.labkey.test.params.FieldKey.child(FieldKey.java:111)
        at org.labkey.test.params.FieldKey.fromParts(FieldKey.java:52)
        at org.labkey.test.params.FieldKey.fromFieldKey(FieldKey.java:76)
        at org.labkey.test.components.ui.grids.FieldReferenceManager.lambda$2(FieldReferenceManager.java:63)
        [...]
        at org.labkey.test.components.ui.grids.FieldReferenceManager.findFieldReference(FieldReferenceManager.java:72)
        at org.labkey.test.components.ui.grids.FieldReferenceManager.findFieldReferenceOrNull(FieldReferenceManager.java:80)
        at org.labkey.test.util.DataRegionTable$Elements.getColumnIndex(DataRegionTable.java:1532)
        at org.labkey.test.util.DataRegionTable.getColumnIndexStrict(DataRegionTable.java:421)
        at org.labkey.test.util.DataRegionTable.getDataAsText(DataRegionTable.java:675)

Related Pull Requests

Changes

  • Make FieldKey.fromFieldKey return null for invalid input

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward revert of a recent change. Maybe worth a comment as to why it's importing to return null to prevent future similar attempts?

@labkey-tchad labkey-tchad merged commit a45c1f4 into develop Jun 28, 2025
6 checks passed
@labkey-tchad labkey-tchad deleted the fb_fixFieldRefManagerNpe branch June 28, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants