Skip to content

Selenium test for GitHub Issue 915: Bulk edit doesn't completely remove attachments for sources #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XingY wants to merge 1 commit into
base: develop
Choose a base branch
from
+19 −0
Open

Selenium test for GitHub Issue 915: Bulk edit doesn't completely remove attachments for sources #2934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/org/labkey/test/components/ui/entities/EntityBulkUpdateDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.labkey.test.components.react.FilteringReactSelect;
import org.labkey.test.components.react.ReactDateTimePicker;
import org.labkey.test.components.react.ToggleButton;
import org.labkey.test.components.ui.files.AttachmentCard;
import org.labkey.test.components.ui.files.FileAttachmentContainer;
import org.labkey.test.components.ui.files.FileUploadField;
import org.labkey.test.params.FieldDefinition;
Expand Down Expand Up @@ -294,6 +295,24 @@ public EntityBulkUpdateDialog removeFile(CharSequence fieldIdentifier)
return this;
}

/**
* Removes an existing attachment displayed as an {@link AttachmentCard} in the bulk update dialog.
* This is used when the rows being edited already have an attachment — the existing file is shown
* as an AttachmentCard with a dropdown menu containing "Remove attachment".
*
* @param fieldIdentifier Identifier for the field; name ({@link String}) or fieldKey ({@link FieldKey})
* @return this component
*/
public EntityBulkUpdateDialog removeExistingAttachment(CharSequence fieldIdentifier)
{
var row = getFileField(fieldIdentifier);
// setEditableState(fieldIdentifier, true);
// WebElement row = elementCache().formRow(fieldIdentifier);
AttachmentCard card = new AttachmentCard.FileAttachmentCardFinder(getDriver()).waitFor(row);
card.clickRemove();
return this;
}

public FileUploadField getExistingFileCard(CharSequence fieldIdentifier)
{
FieldKey identifier = FileAttachmentContainer.fileUploadFieldKey(fieldIdentifier);
Expand Down
Loading