Skip to content

Give more helpful feedback when remote connection fails #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 1 commit into from
Jun 7, 2026
+30 −1
Merged

Give more helpful feedback when remote connection fails #3036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/org/labkey/test/util/RemoteConnectionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,18 @@ public boolean testConnection(String name)
return success;
}

/** Test the named connection, expecting failure with an error message starting with the given prefix. The full message may include environment-specific exception text. */
public void testConnectionExpectFailure(String name, String expectedErrorPrefix)
{
WebElement target = findConnectionStrict(name, "test");
_test.clickAndWait(target, _test.getDefaultWaitForPage());
_test.assertTextPresent("not successful");
String error = getDisplayedError();
Assert.assertNotNull("No error message shown on connection test failure page", error);
Assert.assertTrue("Expected error message to start with '" + expectedErrorPrefix + "' but was: " + error, error.startsWith(expectedErrorPrefix));
_test.clickAndWait(Locator.linkWithText("Manage Remote Connections"));
}

public void createConnection(String name, String url, String container, String user, String password, String expectedError)
{
_test.clickAndWait(Locator.linkWithText("Create New Connection"));
Expand All @@ -61,6 +73,18 @@ public void createConnection(String name, String url, String container, String u
verifyExpectedError(expectedError);
}

/** Expect the save to fail with an error message starting with the given prefix. The full message may include environment-specific exception text. */
public void createConnectionExpectErrorPrefix(String name, String url, String container, String user, String password, String expectedErrorPrefix)
{
_test.clickAndWait(Locator.linkWithText("Create New Connection"));
setConnectionProperties(name, url, container, user, password);
_test.clickButton("save");
String error = getDisplayedError();
Assert.assertNotNull("No error message shown after attempting to save connection", error);
Assert.assertTrue("Expected error message to start with '" + expectedErrorPrefix + "' but was: " + error, error.startsWith(expectedErrorPrefix));
_test.clickButton("cancel");
}

public void editConnection(String name, String newName, String newUrl, String newContainer, String newUser, String newPassword)
{
editConnection(name, newName, newUrl, newContainer, newUser, newPassword, null);
Expand Down Expand Up @@ -137,12 +161,17 @@ private void verifyExpectedError(String expectedError)
{
if (null != expectedError)
{
String error = Locators.labkeyError.findOptionalElement(_test.getDriver()).map(WebElement::getText).orElse(null);
String error = getDisplayedError();
Assert.assertEquals("Remote connection error.", expectedError, error);
_test.clickButton("cancel");
}
}

private String getDisplayedError()
{
return Locators.labkeyError.findOptionalElement(_test.getDriver()).map(WebElement::getText).orElse(null);
}

private WebElement findConnection(String name, String action)
{
List<WebElement> items = Locator.xpath("//a[contains(text(), '" + action + "')]").findElements(_test.getDriver());
Expand Down