Skip to content

Conversation

@dariocazzani
Copy link
Contributor

What does this PR do?

Fixes config management so experiments load their saved settings instead of reverting to defaults on restart. Migrates codebase from string paths to pathlib.Path objects for cleaner path operations.

  • Adds load_or_create_config() to check experiment folder for existing config before creating defaults
  • Moves torch.manual_seed() from global scope to main() for proper experiment-specific seeding
  • Migrates TextProvider classes to use Path and replaces os.walk() with path.rglob()
  • Updates CLI args and model I/O functions (get_tokenizer, load_model) to use Path instead of str
  • Adds rich pretty printing with rpprint(config.model_dump(), indent_guides=True, expand_all=True)

@dariocazzani dariocazzani requested a review from ayeganov August 28, 2025 09:00
Copy link
Contributor

@ayeganov ayeganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@dariocazzani dariocazzani merged commit 83ca9bc into main Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants