Jtso/ontology #118
Merged
Jtso/ontology #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng at classifications. Also now successfully adds options with the add_option() method
… you want to inherit an ontology from a different project. also updated options to return an object class and insert nested_classes to Tool and Option
msokoloff1
suggested changes
Mar 10, 2021
Contributor
msokoloff1
left a comment
msokoloff1
left a comment
There was a problem hiding this comment.
Looks pretty solid! I just have a few minor things that I would like to see changed. Also longer term we might want to support type checking. Right now there is still a chance of creating invalid ontologies even if you pass in the required fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files written under pep8 via yapf format updating
ontology_generator classes moved to ontology file
ontology tests updated and tested to all pass