Skip to content

Remove sleep between creating and exporting a batch #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Remove sleep between creating and exporting a batch #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1285931
add sleep after batch creation to fix flaky test
attila-papai Aug 17, 2023
e82ccbb
add sleep after batch creation to fix flaky test
attila-papai Aug 17, 2023
855f380
Merge branch 'attila/add-sleep-batch' of github.com:Labelbox/labelbox…
attila-papai Aug 17, 2023
c778818
remove time sleeps before batch export
attila-papai Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/integration/export_v2/test_legacy_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ def test_export_data_rows(project: Project, dataset: Dataset):

data_rows = [dr.uid for dr in list(dataset.export_data_rows())]
batch = project.create_batch("batch test", data_rows)

result = list(batch.export_data_rows())
exported_data_rows = [dr.uid for dr in result]

Expand Down
2 changes: 0 additions & 2 deletions tests/integration/test_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,6 @@ def test_export_data_rows(project: Project, dataset: Dataset):

data_rows = [dr.uid for dr in list(dataset.export_data_rows())]
batch = project.create_batch("batch test", data_rows)
# allow time for catapult to sync changes to ES
time.sleep(5)
result = list(batch.export_data_rows())
exported_data_rows = [dr.uid for dr in result]

Expand Down
2 changes: 0 additions & 2 deletions tests/integration/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,6 @@ def test_create_batch_with_global_keys_sync(project: Project, data_rows):
global_keys = [dr.global_key for dr in data_rows]
batch_name = f'batch {uuid.uuid4()}'
batch = project.create_batch(batch_name, global_keys=global_keys)
# allow time for catapult to sync changes to ES
time.sleep(5)
# TODO: Move to export_v2
batch_data_rows = set(batch.export_data_rows())
assert batch_data_rows == set(data_rows)
Expand Down